[Xcb] [PATCH lib] Make xsltproc optional

[Uli Schlachter]

On 31.12.2012 12:09, Daniel Martin wrote:
> Fix Bug 23863 - xcb still checks for xsltproc:
>     https://bugs.freedesktop.org/show_bug.cgi?id=23863
> 
> xsltproc is used to generate the optional html page for `check` results,
> only. So, it's not a hard build dependency.
> 
> Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> ---
>  configure.ac | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7364383..6a28dd1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -27,13 +27,10 @@ AC_LIBTOOL_WIN32_DLL
>  AC_PROG_LIBTOOL
>  AC_PROG_CC
>  
> -AC_PATH_PROG(XSLTPROC, xsltproc, no)
> -if test "$XSLTPROC" = "no"; then
> -   AC_MSG_ERROR([XCB requires xsltproc.])
> -fi
> -
> +XSLTPROC=no
>  HTML_CHECK_RESULT=false
>  if test x"$HAVE_CHECK" = xyes; then
> +	AC_PATH_PROG(XSLTPROC, xsltproc, no)
>  	if test x"$XSLTPROC" != xno; then
>  		HTML_CHECK_RESULT=true
>  	fi
> @@ -294,3 +291,6 @@ echo ""
>  echo "  Installation:"
>  echo "    Prefix..............: ${prefix}"
>  echo ""
> +echo "  Unit tests"
> +echo "    build...............: ${HAVE_CHECK}"
> +echo "    html results........: ${HTML_CHECK_RESULT}"

We already have this in configure.ac:

echo "  Configuration"
echo "    XDM support.........: ${have_xdmcp}"
echo "    Build unit tests....: ${HAVE_CHECK}"
echo "    XCB buffer size.....: ${xcb_queue_buffer_size}"

So with your patch, this prints HAVE_CHECK twice.

(The rest of this patch looks fine to me)

Cheers,
Uli
-- 
Q: Because it reverses the logical flow of conversation.
A: Why is putting a reply at the top of the message frowned upon?