[Xcb] [PATCH] silence some compiler warnings in xcb/util-cursor

Michael Stapelberg michael+xcb at stapelberg.de
Sun Aug 18 10:14:45 PDT 2013


Hi Niclas,

Sorry for the late reply, I was at DebConf and rather busy.

Niclas Zeising <zeising at daemonic.se> writes:
> The issue is that in "cursor.h" you have:
>
> typedef struct xcb_cursor_context_t { ... };
>                                           ^
> Which is missing a typedef name.  However, in "xcb_cursor.h" there is
> already a typedef struct xcb_cursor_context_t xcb_cursor_context_t;.
> "xcb_cursor.h" is included in "cursor.h" so the typedef already exists,
> and there is no need to redo it at all in "cursor.h".  All you need to
> do there is define the struct.
Thanks for the explanation. I committed this:

http://cgit.freedesktop.org/xcb/util-cursor/commit/?id=9a30b01e

Is the code now in a shape that is fit for release from your FreeBSD
point of view?

-- 
Best regards,
Michael


More information about the Xcb mailing list