[Xcb] [PATCH] xfixes: Update to version 5

[Peter Harris]

On 2013-02-05 13:57, Neil Roberts wrote:
> Hi,
> 
> Here is a patch to update the XFixes support to version 5.

Looks good. Thanks. There is one thing you can do to make it better (see
below).

> diff --git a/src/xfixes.xml b/src/xfixes.xml
> index 9bbeaab..80c2292 100644
> --- a/src/xfixes.xml
> +++ b/src/xfixes.xml
> @@ -331,4 +331,25 @@ authorization from the authors.
>    <request name="ShowCursor" opcode="30">
>      <field type="WINDOW" name="window" />
>    </request>
> +
> +  <!-- Version 5 -->
> +
> +  <xidtype name="BARRIER" />

Please add <enum name="DirectionMask"> (see "SelectionEventMask" for an
example) here.

> +    <field type="CARD16" name="x2" />
> +    <field type="CARD16" name="y2" />
> +    <field type="CARD32" name="directions" />

  +    <field type="CARD32" name="directions" mask="DirectionMask" />

> +    <pad bytes="2" />

Thanks,
 Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866