[Xcb] [PATCH proto 1/2] xkb: Work around alignment problem in GetNames reply

Peter Harris pharris at opentext.com
Tue Jul 23 06:30:15 PDT 2013

On 2013-07-23 06:33, Ran Benita wrote:
> The situation is: a list of CARD8s followed by a list of ATOMs (4
> bytes). In the current code, the second list is aligned to 1 byte
> according the size of the CARD8 list, so in effect it follows the first
> list immediately. However, the second list needs to be aligned to 4 bytes
> (see XkbPaddedSize in the server and Xlib).
> Signed-off-by: Ran Benita <ran234 at gmail.com>

I'm always in favour of explicit padding.

Reviewed-by: Peter Harris <pharris at opentext.com>

Peter Harris
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866

More information about the Xcb mailing list