[Xcb] [PATCH proto] xkb: Change DfltBtnAbsolute to the value used by the server

Daniel Martin consume.noise at gmail.com
Sun Jul 28 12:18:22 PDT 2013


On Fri, Jul 26, 2013 at 01:54:46AM +0300, Ran Benita wrote:
> Here's another small fix I've noticed (attached - I have to send it
> from a web interface, sorry!).

No problem. Just included it for the reply:

> From f4d063471882872928bca82dbedb175eba744caf Mon Sep 17 00:00:00 2001
> From: Ran Benita <ran234 at gmail.com>
> Date: Fri, 25 Jul 2013 18:22:53 +0300
> Subject: [PATCH] xkb: Change DfltBtnAbsolute to the value used by the server
> 
> The spec says:
>      #x02     XkbSA_DfltBtnAbsolute
> But /usr/include/X11/extensions/XKB.h has:
>      #define	XkbSA_DfltBtnAbsolute	(1L << 2)
> which is what the server sends.
> 
> Signed-off-by: Ran Benita <ran234 at gmail.com>
> ---
>  src/xkb.xml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/xkb.xml b/src/xkb.xml
> index 9bd326d..323909c 100644
> --- a/src/xkb.xml
> +++ b/src/xkb.xml
> @@ -874,7 +874,8 @@ authorization from the authors.
>  	</struct>
>  
>  	<enum name="SASetPtrDfltFlag">
> -		<item name="DfltBtnAbsolute">  <bit>1</bit> </item>
> +        <!-- The spec says 0x02 but Xlib uses 0x04. -->
> +		<item name="DfltBtnAbsolute">  <bit>2</bit> </item>
>  		<item name="AffectDfltButton"> <bit>0</bit> </item>
>  	</enum>
>  
> -- 
> 1.8.3.3
> 

Reviewed-by: Daniel Martin <consume.noise at gmail.com>

I'll file a patch to adjust the xkb spec accordingly. ;)


More information about the Xcb mailing list