[Xcb] [PATCH proto 5/7 v2] randr: Version bump 1.3..1.4

[Peter Harris]

On 2013-05-28 11:43, Daniel Martin wrote:
> Add the requests of version 1.4 to handle provider objects.

Hooray, a power plant! I can't resist commenting on the colour of the
bikeshed attached to it, though:

> +	<enum name="ProviderCapability">
> +		<item name="None">          <value>0</value></item>
> +		<item name="SourceOutput">  <value>1</value></item>
> +		<item name="SinkOutput">    <value>2</value></item>
> +		<item name="SourceOffload"> <value>4</value></item>
> +		<item name="SinkOffload">   <value>8</value></item>
> +	</enum>

Please remove None, we already have XCB_NONE. The rest of them should be
<bit>0</bit> through <bit>3</bit>.

> +	<request name="GetProviderInfo" opcode="33">
> +		<field type="PROVIDER" name="provider" />
> +		<field type="TIMESTAMP" name="config_timestamp" />
> +		<reply>
...
> +			<list type="char" name="name">
> +				<fieldref>name_len</fieldref>
> +			</list>
> +			<list type="void" name="alignment_pad">
> +				<op op="-">
> +					<op op="&">
> +						<op op="+">
> +							<fieldref>name_len</fieldref>
> +							<value>3</value>
> +						</op>
> +						<unop op="~">
> +							<value>3</value>
> +						</unop>
> +					</op>
> +					<fieldref>name_len</fieldref>
> +				</op>
> +			</list>
> +		</reply>

alignment_pad is only really necessary between lists (and sometimes at
the end of a struct), not at the end of the request/reply. That said,
I'm not going to object if you leave it in. (I wouldn't even comment if
we could spell it <pad align="4" />, but that's for another day).

The parts of the rest of it that I looked at are good.

With the enum change, Reviewed-by: Peter Harris <pharris at opentext.com>

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866