[Xcb] [PATCH 3/6] Add support for file descriptor request fields

Daniel Martin consume.noise at gmail.com
Thu Nov 7 06:09:12 PST 2013

On 7 November 2013 13:04, Keith Packard <keithp at keithp.com> wrote:
> Daniel Martin <consume.noise at gmail.com> writes:
>> The <fd> tag is not necessary. It should be an ordinary field - as it
>> gets handled.
> I prefer using a separate tag as '<field>' tags now universally mean
> bytes encoded on the wire, and '<fd>' elements are strictly *not* on the
> wire in the usual sense.
> It's not a different data type, it's taking an entirely different route
> over the network.

Damn, so I was at the correct line:
    new_fd = Field(self, module.get_type_name('INT32'), fd_name, True,
False, False, None, True)
but didn't read it correctly, as the first False is for 'wire'. m(
(Lot's of places in the code would benefit from keyword arguments.)

Still I think that an attribute would've been better. Anyways,
if you could add the modification for the xml schema it's:

Reviewed-by: Daniel Martin <consume.noise at gmail.com>

More information about the Xcb mailing list