[Xcb] [Bug 68387] xinput2 XIQueryDevice reply not read correctly

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 20 00:55:54 PST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=68387

Daniel Martin <consume.noise at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89413|0                           |1
        is obsolete|                            |

--- Comment #8 from Daniel Martin <consume.noise at gmail.com> ---
Created attachment 89518
  --> https://bugs.freedesktop.org/attachment.cgi?id=89518&action=edit
reset xcb_block_len (with commit message)

Thanks Ran for sanitizing the patch.

In this updated version I've added myself as reviewer and removed the
preceeding 2 lines:
    # probably not needed
    #_c_serialize_helper_insert_padding(context, code_lines, space, False)

The _c_serialize_helper_insert_padding() had been commented out with:
    22e1013 added accessors for special cases
and thereby partly caused that regression. Partly because, the implicit padding
would set xcb_block_len to zero as we want, but the implicit padding itself
might lead to other length/offset calculation problems.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20131120/20b97b21/attachment.html>


More information about the Xcb mailing list