[Xcb] [PATCH 2/8] -pendantic is too pendantic

[Gaetan Nadon]

On 13-11-27 02:50 AM, Ran Benita wrote:
> Hi Gaetan,
>
> On Tue, Nov 26, 2013 at 07:02:23PM -0500, Gaetan Nadon wrote:
>> On 13-11-26 06:33 PM, Ran Benita wrote:
>>> This was already committed, but how about changing to AC_CC_C99 instead?
>> Pardon me as I am out of context. The xserver module is configured with
>> AC_PROG_CC_C99 that gets pulled in by XORG_DEFAULTS from util-macros.
>> It's not obvious, but it saves from copying this line in the 250 xorg
>> modules.
> Problem is, xcb doesn't use util-macros. I like it myself.
ooops, I was indeed out of context. Usually [PATCH] without a name
implies xserver.
>
>> That's why we ask developers not to add AC_PROG_CC in configure.ac as it
>> turns the module back to C89. That isn't obvious either :-)
>>
>> To find which of the two a module is using:
>>
>>     grep "^CC=" config.status
>>
>> and you get:
>>
>>     CC='gcc -std=gnu99'
>>
>>
>> There are also a couple of options to fine tune the level of strictness:
>>
>>       --disable-selective-werror
>>                               Turn off selective compiler errors. (default:
>>                               enabled)
> Didn't know about this one, used to do this manually sometimes.
Added in 2011 by Jeremy Huddleston

    Provide a configure option to turn off the selective -Werror=... CFLAGS

    Provide end users with a workaround if they find code doesn't build
    with the -Werror=... flags provided by BASE_CFLAGS. This can be
    useful if newer util-macros are used with older source code that had
    problems, or in the rare case when warnings are expanded to hit more
    cases (although this case should not happen too much in practice).


Cheers!

>> _______________________________________________
>> xorg-devel at lists.x.org: X.Org development
>> Archives: http://lists.x.org/archives/xorg-devel
>> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20131127/7c2800eb/attachment.html>