[Xcb] Next Release?

[Arnaud Fontaine]

Hello,

Peter Harris <pharris at opentext.com> writes:

> On 2013-10-04 06:47, Arnaud Fontaine wrote:
>> Peter Harris <pharris at opentext.com> writes:
>> 
>>> My short-term plan, if I ever get a free minute, is to convert the
>>> events into structs (deleting the type field) and add one event that
>>> contains the type and a union with all the structs.
>> 
>> Done by Daniel Martin but not merged yet:
>> http://lists.freedesktop.org/archives/xcb/2013-August/008541.html
>> 
>> Should it be merged?
>
> Yes, plesae.
>
> It appears I forgot to review Daniel's patch at the time. I'll do so now:
>
> Reviewed-by: Peter Harris <pharris at opentext.com>
>
>> * [Bug 68387] New: xinput2 XIQueryDevice reply not read correctly
>>   https://bugs.freedesktop.org/show_bug.cgi?id=68387
>
> Yes, please. Looks like Ran Benita both reviewed and tested this patch.

Concerning this patch and the ones above, Daniel Martin asked me to hold
off a week to see if can finish his parser rewrite to handle
<switch>/<case> in XML description. As this rewrite would break the API,
I think it's better to wait a week and see how it goes...

Therefore I have not merged the following patches:

* [Bug 68387] New: xinput2 XIQueryDevice reply not read correctly
  https://bugs.freedesktop.org/show_bug.cgi?id=68387

* [PATCH proto 1/3] xkb: Comment out Doodads
  http://lists.freedesktop.org/archives/xcb/2013-August/008539.html
  => Reviewed-By: Ran Benita <ran234 at gmail.com>

  * [PATCH proto 3/3] xkb: Unify events into single event
    http://lists.freedesktop.org/archives/xcb/2013-August/008541.html
    => Tested-By: Ran Benita <ran234 at gmail.com>

* [PATCH 1/1] XKB: Fix values of AXFBOpt enum
  http://lists.freedesktop.org/archives/xcb/2013-September/008668.html
  => Reviewed-By: Ran Benita <ran234 at gmail.com>

  * [Xcb] [PATCH 2/1] XKB: Rewrite AXOption
    http://lists.freedesktop.org/archives/xcb/2013-September/008669.html
    => Reviewed-By: Ran Benita <ran234 at gmail.com>

Please correct me if I have misunderstood something.

Moreover, As per Daniel's request, I have also merged these patches:
https://github.com/bartsch/xcb-proto/tree/next-for-master

>> * [Bug 69118] New: Unix spool is located at /var/spool/sockets/X11/... or /usr/spool/sockets/X11/... under HPUX
>>   https://bugs.freedesktop.org/show_bug.cgi?id=69118
>
> Yes, please. The "Simpler patch." version clearly can't hurt anybody not
> using HPUX. And anybody still using HPUX is used to hurt by now.

Merged, thanks.

Uli Schlachter <psychon at znc.in> writes:

> Yeah, I agree. Although I can already see that this means "Don't call into xcb
> while holding the Xlib lock" and the patch never gets merged.
>
> So feel free to revert 9ae84ad187e (unless someone else says otherwise?).

Let's wait until Daniel's email about the rewrite in case a consensus has
been reached meanwhile if that's ok with you.

Cheers,
-- 
Arnaud Fontaine