[Xcb] [PATCH 7/7] xkb: Add struct Property as per spec (commented out)

Daniel Martin consume.noise at gmail.com
Sun Oct 13 04:44:41 PDT 2013


From: Ran Benita <ran234 at gmail.com>

The specification says that Property is a struct of two CountedString16
(name and value). This form can't be handled atm. correctly too. But,
add it as a comment so we've it at hand when we know what to do with it.

All credits go to Ran Benita, as he found this.

Signed-off-by: Daniel Martin <consume.noise at gmail.com>
---
Here've set Ran as author. Because, he found this:
    Alignment problems in XKB GetGeometry
    http://lists.freedesktop.org/archives/xcb/2013-August/008448.html

If that's wrong or Ran doesn't like it, then ignore the patch, please.

 src/xkb.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/xkb.xml b/src/xkb.xml
index e0ad022..ea7fbb0 100644
--- a/src/xkb.xml
+++ b/src/xkb.xml
@@ -567,6 +567,14 @@ <struct name="Property">
 		</list>
 	</struct>
 	-->
+	<!-- XXX: This would be the correct Property structure as per spec.,
+		  but it's broken atm. too. Add it anyway here, so we don't
+		  loose that information.
+	<struct name="Property">
+		<field name="name" type="CountedString16" />
+		<field name="value" type="CountedString16" />
+	</struct>
+	-->
 
 	<struct name="Outline">
 		<field name="nPoints" type="CARD8" />
-- 
1.8.4



More information about the Xcb mailing list