[Xcb] [Bug 70680] New: reserved identifier violation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70680

          Priority: medium
            Bug ID: 70680
          Assignee: xcb at lists.freedesktop.org
           Summary: reserved identifier violation
        QA Contact: xcb at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: Markus.Elfring at web.de
          Hardware: All
            Status: NEW
           Version: 1.0
         Component: Library
           Product: XCB

I would like to point out that identifiers like "__XCB_H__" and "__XCBEXT_H" do
not fit to the expected naming convention of the C language standard.
http://cgit.freedesktop.org/xcb/libxcb/tree/src/xcb.h?id=ac47e0ecdb46aa91b191a59364437a8f65947467#n28
http://cgit.freedesktop.org/xcb/libxcb/tree/src/xcbext.h?id=9ae84ad187e2ba440c40f44b8eb21c82c2fdbf12#n28

Would you like to adjust your selection for unique names?
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20131020/d4bc61e3/attachment.html>