[Xcb] [PATCH] util-cursor: Fix minor memleak and fix the RENDER version check

[Bart Massey]

I'm confused about the first patch. Shouldn't you be checking whether
the resource string is null before freeing it, rather than freeing it
unconditionally?

Second patch looks fine.
Reviewed-By: Bart Massey <bart at cs.pdx.edu>

On Thu, Sep 19, 2013 at 9:21 AM, Uli Schlachter <psychon at znc.in> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hi,
>
> attached are two patches for util-cursor. The first one handles a minor memory
> leak and is quite trivial.
>
> The second one is a little less trivial: CreateCursor was added to RENDER in
> version 0.5 and CreateAnimCursor is new in version 0.8. However, util-cursor
> only checked if the RENDER extension is present and then assumed that all
> requests are available.
>
> Cheers,
> Uli
> - --
> <alanc> I think someone had a Xprint version of glxgears at one point,
>     but benchmarking how many GL pages you can print per second
>     was deemed too silly to merge
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
>
> iQEcBAEBCAAGBQJSOySFAAoJECLkKOvLj8sGpJgH/1zTOdMyZBiC4YTQ4aos2b5Q
> 0dKkD8B4R5o9DTlZz/ZEOBWAerKoQdpa52e0Bff8z9OO0yxaNUl/WLA/1yObkzgB
> Svc1LxCI7eX8+35lxPFPcNrU0e5IOXzTKu36VPO+aEPIknHOHNaSIKwDsNLiOOKy
> s1TBUBwMFs3fET8brXw2DRRcHYyGcGAus+ZYk7fCHIl1jtRpgRInxp++Poy72niV
> yIvrYAyBwKCY7dzAejiQK6KO87LBdBtlp4S8wYL+AueMUZeqXQrk7KyXyI0+ySrs
> tnzwgkoErLdtGt1UOh52nBIzDqAHQcnamwPWQoOP4kyO7C7PqCeHQbM7avhcC7o=
> =jIoE
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb