[Xcb] [PATCH proto] Remove extraneous spaces between <value> tags

Uli Schlachter psychon at znc.in
Thu Apr 10 07:28:22 PDT 2014


On 10.04.2014 03:34, Vincent W. Chen wrote:
> These are the only places where spaces are allowed between <value> tags.
> This is not only inconsistent but also complicates the parsing of values
> as integers.

This looks simple enough that I just went ahead and merged it (commit
a37c762e33f). However, I am not saying anything about if these spaces were
actually wrong or not.

Uli

> ---
>  src/dri2.xml        | 2 +-
>  src/xf86vidmode.xml | 2 +-
>  src/xinput.xml      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/dri2.xml b/src/dri2.xml
> index 0160c6b..20d6649 100644
> --- a/src/dri2.xml
> +++ b/src/dri2.xml
> @@ -98,7 +98,7 @@ authorization from the authors.
>  	      <op op="&">
>  		  <op op="+">
>  		      <fieldref>driver_name_length</fieldref>
> -		      <value> 3 </value>
> +		      <value>3</value>
>  		  </op>
>  		  <unop op="~">
>  		      <value>3</value>
> diff --git a/src/xf86vidmode.xml b/src/xf86vidmode.xml
> index 9dacaef..a165c11 100644
> --- a/src/xf86vidmode.xml
> +++ b/src/xf86vidmode.xml
> @@ -159,7 +159,7 @@ authorization from the authors.
>  		    <op op="&">
>  			<op op="+">
>  			    <fieldref>vendor_length</fieldref>
> -			    <value> 3 </value>
> +			    <value>3</value>
>  			</op>
>  			<unop op="~">
>  			    <value>3</value>
> diff --git a/src/xinput.xml b/src/xinput.xml
> index fa115bd..924c003 100644
> --- a/src/xinput.xml
> +++ b/src/xinput.xml
> @@ -1000,7 +1000,7 @@ authorization from the authors.
>      <!-- ChangeDeviceProperty -->
>  
>      <enum name="PropertyFormat">
> -        <item name="8Bits">  <value> 8</value> </item>
> +        <item name="8Bits">  <value>8</value> </item>
>          <item name="16Bits"> <value>16</value> </item>
>          <item name="32Bits"> <value>32</value> </item>
>      </enum>
> 


-- 
"For saving the Earth.. and eating cheesecake!"


More information about the Xcb mailing list