[Xcb] [PATCH proto] xprint: Fix <field type="STRING8"> in PrintGetAttributes reply

Peter Harris pharris at opentext.com
Fri Apr 11 14:51:35 PDT 2014


On 2014-04-10 21:52, Vincent Chen wrote:
> On Thu, Apr 10, 2014 at 8:17 AM, Peter Harris <pharris at opentext.com> wrote:
>> On 2014-04-09 21:48, Vincent W. Chen wrote:
>>> The reply for PrintGetAttributes contains a field of type STRING8, which
>>> makes no sense as the STRING8 type is only used to denote a string. This
>>> has been changed to <list type="STRING8"> with field "stringLen" as its
>>> length.
>>
>> Woah. Someone still uses xprint?
>>
>> Good catch. Reviewed-by: Peter Harris <pharris at opentext.com>
>>
> Nah, nobody uses xprint anymore. I'm just currently working on
> generating a Java binding from xcb-proto and my parser refuses to
> parse this. Good thing it's a bug with proto and not my parser ;-)

Pushed. Thanks for the patch.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list