[Xcb] [PATCH util-image 00/12] Upgrade package configuration

[Uli Schlachter]

Hi,

On 04.04.2014 01:33, Gaetan Nadon wrote:
> In version 2, patches #1,4,5,6,7,8 and 10 have not changed.
> Patch #9 was not viewed as it was delayed in the list.
> Patches #11 and #12 are new patches as a result of review feedback.
> 
> Gaetan Nadon (12):
>   config: add bug URL to AC_INIT
>   config: replace deprecated use of AC_OUTPUT with AC_CONFIG_FILES
>   config: remove old dead code for documentation
>   config: use AC_CONFIG_HEADERS to create a config.h file
>   config: add missing COPYING file
>   make: there should be no attempt to remove any Makefile.in file
>   make: using EXTRA_DIST for xcb-util-image.pc.in is redundant
>   make: image is using X11 Protcol headers, so XPROTO_CFLAGS is
>     required
>   test: move test cases into their own directory
>   image: use AM_CPPFLAGS rather than per-target
>     libxcb_image_la_CPPFLAGS
>   Replace _X_INLINE with "inline" along with AC_C_INLINE
>   Drop dependency on X11 Protocol package

Patches 1 to 10 are (with my comments addressed):

Reviewed-by: Uli Schlachter <psychon at znc.in>

I'm not sure if 11 (and thus 12) really can work...

For the next round, I would propose that you just send a pull request. Everyone
who wants to review things had enough time for doing so.

>  .gitignore                           |    1 -
>  COPYING                              |   27 +++++++++++++++++++++++
>  Makefile.am                          |    2 +-
>  configure.ac                         |   18 ++++++++++-----
>  image/Makefile.am                    |   40 ++++------------------------------
>  image/xcb_bitops.h                   |   17 +++++++--------
>  image/xcb_image.c                    |    4 ++++
>  image/xcb_pixel.h                    |   21 +++++++++---------
>  {image => test}/.gitignore           |    0
>  test/Makefile.am                     |   29 ++++++++++++++++++++++++
>  {image => test}/test.xbm             |    0
>  {image => test}/test_bitmap.c        |    0
>  {image => test}/test_formats.c       |    0
>  {image => test}/test_swap.c          |    0
>  {image => test}/test_xcb_image.c     |    0
>  {image => test}/test_xcb_image_shm.c |    0
>  xcb_util_intro.in                    |   24 --------------------
>  17 files changed, 95 insertions(+), 88 deletions(-)
>  create mode 100644 COPYING
>  rename {image => test}/.gitignore (100%)
>  create mode 100644 test/Makefile.am
>  rename {image => test}/test.xbm (100%)
>  rename {image => test}/test_bitmap.c (100%)
>  rename {image => test}/test_formats.c (100%)
>  rename {image => test}/test_swap.c (100%)
>  rename {image => test}/test_xcb_image.c (100%)
>  rename {image => test}/test_xcb_image_shm.c (100%)
>  delete mode 100644 xcb_util_intro.in

Cheers,
Uli
-- 
Do Not Touch The Jellyfish! Get Me To The Hosp Immediately