[Xcb] xinput.xml: patches for padding errors in the middle of requests

Ran Benita ran234 at gmail.com
Thu Aug 14 03:14:19 PDT 2014

On Wed, Aug 13, 2014 at 03:37:22PM +0200, Christian Linhart wrote:
> Hi again,
> In the next two posts I'll send the patches for the first category of errors:
> "padding errors in the middle of requests" 
> ( these are rather critical bugs )

I'm pretty sure there's implicit padding in these cases (at least in
libxcb, the structs are not packed). But explicit padding is much
better. For both patches:

Reviewed-by: Ran Benita <ran234 at gmail.com>

> I will post the patches for the other categories later.
> I hope it is OK like this.

It is. On top of what Peter said, since you'll be sending many patches I
have two suggestions (you don't have to follow them if it takes too much

1. Apply the tip in proto/HACKING - it makes the patches a bit nicer to
   read by proving more relevant context.
2. Quote the specs/header files in-line in the commit message (with a
   link if you're really nice :). Then we can review just by looking at
   the patch. Also the spec/headers may get out of sync in the future.


> Chris
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb

More information about the Xcb mailing list