[Xcb] [PATCH proto 01/22] xinput: enum InputClass: comment value Attach 7

Christian Linhart chris at demorecorder.com
Mon Aug 18 05:59:41 PDT 2014

The value Attach=7 is defined in XI.h but not supported anymore by libXi.
And it never was transmitted over the protocol.
(It was used to tag a fake class created by libXi)

Add this comment so that future reviews will not accidentally add this value.


drop of support in libXi:
 src/xinput.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/xinput.xml b/src/xinput.xml
index 459b388..2583036 100644
--- a/src/xinput.xml
+++ b/src/xinput.xml
@@ -85,14 +85,25 @@ <enum name="InputClass">
         <item name="Key">       <value>0</value> </item>
         <item name="Button">    <value>1</value> </item>
         <item name="Valuator">  <value>2</value> </item>
         <item name="Feedback">  <value>3</value> </item>
         <item name="Proximity"> <value>4</value> </item>
         <item name="Focus">     <value>5</value> </item>
         <item name="Other">     <value>6</value> </item>
+        <!--
+               value Attach=7 is still contained in XI.h as "#define AttachClass"
+               but it was never transmitted over the protocol.
+               (It was used to tag a fake class created by libXi).
+               Even the creation of that fake class has been dropped 
+               from libXi in 2009 by the following change:
+               http://cgit.freedesktop.org/xorg/lib/libXi/commit/?id=62858c426e6de1b99df660251737233afd335302
+               <item name="Attach">    <value>7</value> </item>
+        -->
     <enum name="ValuatorMode">
         <item name="Relative"> <value>0</value> </item>
         <item name="Absolute"> <value>1</value> </item>

More information about the Xcb mailing list