[Xcb] [PATCH proto 09/22] xinput: struct ValuatorState.mode: add mask

[Peter Harris]

On 2014-08-18 08:59, Christian Linhart wrote:
>  
> +    <enum name="ValuatorStateModeMask">
> +        <item name="DeviceMode">     <value>1</value> </item>
> +        <item name="ProximityState"> <value>2</value> </item>
> +    </enum>
> +

Masks should contain <bit>, not <value>.

Those name the bits, but they doesn't indicate which way the bit should
be flipped.

Perhaps something like:
+        <item name="DeviceModeAbsolute"> <bit>0</bit> </item>
+        <item name="OutOfProximity">     <bit>1</bit> </item>

Same comment for the same names (bits 6 and 7) in patch 21 of this series.

</bikeshed>

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866