[Xcb] [PATCH proto 17/22] xinput: ev DeviceKeyPress.device_id: add mask

[Peter Harris]

On 2014-08-18 08:59, Christian Linhart wrote:
> diff --git a/src/xinput.xml b/src/xinput.xml
> index cc47694..2dfa591 100644
> --- a/src/xinput.xml
> +++ b/src/xinput.xml
> @@ -1844,15 +1844,15 @@ <event name="DeviceKeyPress" number="1">
>          <field type="WINDOW"    name="child" altenum="Window" />
>          <field type="INT16"     name="root_x" />
>          <field type="INT16"     name="root_y" />
>          <field type="INT16"     name="event_x" />
>          <field type="INT16"     name="event_y" />
>          <field type="CARD16"    name="state" mask="KeyButMask" />
>          <field type="BOOL"      name="same_screen" />
> -        <field type="CARD8"     name="device_id" />
> +        <field type="CARD8"     name="device_id" mask="MoreEventsMask" />

This should be altmask, because all the legal values of device_id are
not described by the <bit> elements of MoreEventsMask.

Same comment for patches 18 through 20.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866