[Xcb] [PATCH proto 16/22] xinput: new enum for device_id in some events

Peter Harris pharris at opentext.com
Mon Aug 18 13:37:37 PDT 2014


On 2014-08-18 08:59, Christian Linhart wrote:
> +    <!-- the highest bit in a CARD8 device_id-field indicates that more
> +	events will follow -->
> +    <enum name="MoreEventsMask">
> +	<item name="DeviceBits"> <value>127</value> </item> <!-- 0x7f -->
> +	<item name="MoreEvents"> <bit>7</bit>       </item> <!-- 0x80 -->
> +    </enum>

I'd be inclined to drop DeviceBits, to avoid mixing <value> and <bit> in
the same enum.

That said, there is precedent for mixing <value> and <bit> in the same
enum in other parts of xcb, so it's not a strong objection.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list