[Xcb] [PATCH proto 20/22 V2] xinput: ev DeviceButtonStateNotify.device_id: mask

Ran Benita ran234 at gmail.com
Fri Aug 22 00:15:57 PDT 2014


On Tue, Aug 19, 2014 at 01:14:08PM +0200, Christian Linhart wrote:
> add mask "MoreEventsMask" to field "device_id"
> 
> V2: patch revised according to suggestion from Peter Harris:
> * use "altmask" instead of "mask" 
>   because all the legal values of device_id are not described 
>   by the <bit> elements of MoreEventsMask.
> 
> spec:
> http://cgit.freedesktop.org/xorg/lib/libXi/tree/specs/encoding.xml#n2252
> http://cgit.freedesktop.org/xorg/xserver/tree/dix/enterleave.c#n725
> 
> note:
> this mask is missing in the following spec:
> http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XIproto.txt#n2431
> ---
>  src/xinput.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xinput.xml b/src/xinput.xml
> index 9b934a6..55db451 100644
> --- a/src/xinput.xml
> +++ b/src/xinput.xml
> @@ -1913,15 +1913,15 @@ <event name="DeviceKeyStateNotify" number="13">
>          <field type="BYTE" name="device_id" mask="MoreEventsMask" />

This patch needs to be regenerated, since after patch 19 V2 this line
changed. Another option is to publish a git repo with your changes in
the expected order.

>          <list type="CARD8" name="keys">
>              <value>28</value>
>          </list>
>      </event>
>  
>      <event name="DeviceButtonStateNotify" number="14">
> -        <field type="BYTE" name="device_id" />
> +        <field type="BYTE" name="device_id" altmask="MoreEventsMask" />
>          <list type="CARD8" name="buttons">
>              <value>28</value>
>          </list>
>      </event>
>  
>      <!-- ⋅⋅⋅ Events (v1.4) ⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅⋅ -->
>  
> -- 2.0.1 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list