[Xcb] [PATCH proto 1/5] xinput: req XIPassiveGrabDevice.time: field is missing in spec

[Peter Hutterer]

On Fri, Aug 22, 2014 at 10:42:43AM +0300, Ran Benita wrote:
> On Mon, Aug 18, 2014 at 04:41:19PM +0200, Christian Linhart wrote:
> > The request-field "time" is missing in the spec
> > but it is contained in the code of XI2proto.h.
> > So, probably the spec has an error.
> > 
> > Add a comment about this, so that future reviewers
> > won't accidentally remove that field.
> 
> Better would be to just fix the spec with a patch for inputproto to
> xorg-devel. Adding Peter Hutterer to CC though, he'd know how to update
> the spec correctly (from a rudimentary look the `time` field doesn't
> seem to be used by the server).

fix pushed to inputproto, thanks.
http://cgit.freedesktop.org/xorg/proto/inputproto/commit/?id=81378a1e7139af9d476d90df8737c0c1a58670f3

Cheers,
   Peter

 
> > 
> > spec:
> > http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XI2proto.txt#n1629
> > 
> > code:
> > http://cgit.freedesktop.org/xorg/proto/inputproto/tree/XI2proto.h#n680
> > ---
> >  src/xinput.xml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/xinput.xml b/src/xinput.xml
> > index 2c8c2b6..72f61fd 100644
> > --- a/src/xinput.xml
> > +++ b/src/xinput.xml
> > @@ -1630,14 +1630,15 @@ <enum name="ModifierMask">
> >      <struct name="GrabModifierInfo">
> >          <field type="CARD32" name="modifiers" altenum="ModifierMask" />
> >          <field type="CARD8"  name="status" enum="GrabStatus" />
> >          <pad bytes="3" />
> >      </struct>
> >  
> >      <request name="XIPassiveGrabDevice" opcode="54">
> > +        <!-- field "time" is missing in the spec, but contained in XI2proto.h -->
> >          <field type="TIMESTAMP" name="time" altenum="Time" />
> >          <field type="WINDOW"    name="grab_window" />
> >          <field type="CURSOR"    name="cursor" />
> >          <field type="CARD32"    name="detail" />
> >          <field type="DeviceId"  name="deviceid" altenum="Device" />
> >          <field type="CARD16"    name="num_modifiers" />
> >          <field type="CARD16"    name="mask_len" />
> > -- 
> > 2.0.1
> > 
> > _______________________________________________
> > Xcb mailing list
> > Xcb at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/xcb
>