[Xcb] [PATCH proto 1/5 V2] xinput: req XIPassiveGrabDevice.time: field is unused

[Ran Benita]

On Mon, Aug 25, 2014 at 12:08:57PM +0200, Christian Linhart wrote:
> The request-field "time" is unused.
> Add a comment about this.
> 
> V2: patch revised according to the following fix in the spec:
> http://cgit.freedesktop.org/xorg/proto/inputproto/commit/?id=81378a1e7139af9d476d90df8737c0c1a58670f3
> 
> spec:
> http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XI2proto.txt?id=81378a1e7139af9d476d90df8737c0c1a58670f3#n1699
> 
> code:
> http://cgit.freedesktop.org/xorg/proto/inputproto/tree/XI2proto.h?id=inputproto-2.3.1#n680

Reviewed-by: Ran Benita <ran234 at gmail.com>

And thanks to Peter for fixing the spec.

> ---
>  src/xinput.xml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/xinput.xml b/src/xinput.xml
> index 2c8c2b6..72f61fd 100644
> --- a/src/xinput.xml
> +++ b/src/xinput.xml
> @@ -1630,14 +1630,15 @@ <enum name="ModifierMask">
>      <struct name="GrabModifierInfo">
>          <field type="CARD32" name="modifiers" altenum="ModifierMask" />
>          <field type="CARD8"  name="status" enum="GrabStatus" />
>          <pad bytes="3" />
>      </struct>
>  
>      <request name="XIPassiveGrabDevice" opcode="54">
> +        <!-- field "time" is unused and its value is undefined -->
>          <field type="TIMESTAMP" name="time" altenum="Time" />
>          <field type="WINDOW"    name="grab_window" />
>          <field type="CURSOR"    name="cursor" />
>          <field type="CARD32"    name="detail" />
>          <field type="DeviceId"  name="deviceid" altenum="Device" />
>          <field type="CARD16"    name="num_modifiers" />
>          <field type="CARD16"    name="mask_len" />
> -- 2.0.1
>