[Xcb] [PATCH proto 1/1] Replace valueparam with switch-bitcase in Screensaver

[Christian Linhart]

Hi Jaya,

Thank you for this patch.

The switch definition is exactly the same as for CreateWindow in your patch for xproto.xml.
This is good because ScreenSaver.SetAttributes has the same value-list as core.CreateWindow
according to the spec:
http://cgit.freedesktop.org/xorg/proto/scrnsaverproto/tree/specs/saver.xml#n653

Therefore this patch looks good:

Reviewed-by: Christian Linhart <chris at demorecorder.com>

Chris


On 12/23/14 18:29, Jaya Tiwari wrote:
> Changed valueparam to switch bitcase in Screensaver for the request
> ScreenSaverSetAttributes
>
> The changes of valueparam to switch has been made as per the specs for
> the extension for the possible values of value-mask and value-list
>
> ScreenSaverSetAttributes:
> http://cgit.freedesktop.org/xorg/proto/scrnsaverproto/tree/specs/saver.xml#n633
> Signed-off-by: Jaya Tiwari <tiwari.jaya18 at gmail.com>
> ---
>  src/screensaver.xml | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 65 insertions(+), 3 deletions(-)
>
> diff --git a/src/screensaver.xml b/src/screensaver.xml
> index 491869e..8d5abb4 100644
> --- a/src/screensaver.xml
> +++ b/src/screensaver.xml
> @@ -95,9 +95,71 @@ <request name="SetAttributes" opcode="3">
>      <field type="BYTE" name="class" enum="WindowClass"/>
>      <field type="CARD8" name="depth"/>
>      <field type="VISUALID" name="visual"/>
> -    <valueparam value-mask-type="CARD32"
> -                value-mask-name="value_mask"
> -                value-list-name="value_list" />
> +    <field type="CARD32" name="value_mask" mask="CW" />
> +    <switch name="value_list">
> +        <fieldref>value_mask</fieldref>
> +        <bitcase>
> +          <enumref ref="CW">BackPixmap</enumref>
> +          <field type="PIXMAP" name="background_pixmap" altenum="BackPixmap"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BackPixel</enumref>
> +          <field type="CARD32" name="background_pixel" />
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BorderPixmap</enumref>
> +          <field type="PIXMAP" name="border_pixmap" altenum="Pixmap"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BorderPixel</enumref>
> +          <field type="CARD32" name="border_pixel" />
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BitGravity</enumref>
> +          <field type="CARD32" name="bit_gravity" enum="Gravity"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">WinGravity</enumref>
> +          <field type="CARD32" name="win_gravity" enum="Gravity"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BackingStore</enumref>
> +          <field type="CARD32" name="backing_store" enum="BackingStore"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BackingPlanes</enumref>
> +          <field type="CARD32" name="backing_planes" />
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">BackingPixel</enumref>
> +          <field type="CARD32" name="backing_pixel" />
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">OverrideRedirect</enumref>
> +          <field type="BOOL32" name="override_redirect" />
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">SaveUnder</enumref>
> +          <field type="BOOL32" name="save_under" />
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">EventMask</enumref>
> +          <field type="CARD32" name="event_mask" mask="EventMask"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">DontPropagate</enumref>
> +          <field type="CARD32" name="do_not_propogate_mask" mask="EventMask"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">Colormap</enumref>
> +          <field type="COLORMAP" name="colormap" altenum="Colormap"/>
> +        </bitcase>
> +        <bitcase>
> +          <enumref ref="CW">Cursor</enumref>
> +          <field type="CURSOR" name="cursor" altenum="Cursor"/>
> +        </bitcase>
> +    </switch>
> +
>    </request>
>
>    <request name="UnsetAttributes" opcode="4">
>
>