[Xcb] [PATCH] Force XCB event structures with 64-bit extended fields to be packed.

[Alan Coopersmith]

On 01/ 3/14 01:17 PM, Kenneth Graunke wrote:
> On 12/31/2013 03:07 AM, Daniel Martin wrote:
>> On Mon, Dec 30, 2013 at 08:31:55PM -0800, Kenneth Graunke wrote:
>>> +#define XCB_PACKED __attribute__((__packed__))
>>
>> Would it be usefull to have such a "packed" abstraction in util-macros
>> to be able to handle it for other compilers (like the _Alignas() from
>> C11, which Mark mentioned) in the future? I see that it wasn't necessary
>> before and might not be used by more libs then xcb soon - or ever.
>
> Yeah, perhaps...putting it there would centralize the compiler-specific
> magic in one place, so it could be done right for all xorg projects.  I
> don't know how many projects will need this, though.

Unfortunately, most of our existing compiler-specific #ifdefs are in x11proto,
which made much more sense before xcb, since xcb doesn't really need most of
what's in that package.

http://cgit.freedesktop.org/xorg/proto/x11proto/tree/Xfuncproto.h.in#n77

Perhaps we should move that out to another package someday, but there's a lot
of dependencies across the existing xorg modules to update when that happens.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc