[Xcb] [proto 1/3] xkb: Add missing modLatches to LatchLockState

Ran Benita ran234 at gmail.com
Wed Jul 16 05:30:01 PDT 2014


On Tue, Jul 15, 2014 at 07:25:16PM +0200, Daniel Martin wrote:
> The field modLatches was missing in the request LatchLockState:
>     http://cgit.freedesktop.org/xorg/proto/kbproto/tree/XKBproto.h#n141

Change looks correct to me, but as always it breaks the existing
users (which according to google do exist). So this needs a major
sobump, or something else, like LatchLockState2... Any suggestions?

Ran

> 
> Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> ---
>  src/xkb.xml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/xkb.xml b/src/xkb.xml
> index 04ab429..c904f6c 100644
> --- a/src/xkb.xml
> +++ b/src/xkb.xml
> @@ -1204,6 +1204,7 @@ <request name="LatchLockState" opcode="5">
>  		<field name="lockGroup" type="BOOL" />
>  		<field name="groupLock" type="CARD8" enum="Group" />
>  		<field name="affectModLatches" type="CARD8" mask="ModMask" />
> +		<field name="modLatches" type="CARD8" mask="ModMask" />
>  		<pad bytes="1" />
>  		<field name="latchGroup" type="BOOL" />
>  		<field name="groupLatch" type="CARD16" />
> -- 
> 2.0.1
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list