[Xcb] Bug 79808 - xcb_xv_query_adaptors

Daniel Martin consume.noise at gmail.com
Mon Jun 9 08:55:03 PDT 2014


Hi folks,

I just had a look at the bug. There needs to be an alignment pad
between the 2 list (name and formats). But, if we just add the padding
we end up with invalid C code as the generator doesn't handle it
correctly.

Therefore, we've to watch out for such conditions and generate differnt
code:
    [PATCH lib] Handle <pad align="n" /> between lists
That was the most simple hack I could think of. It doesn't cause any
other diffs then in the query_adaptors reply related functions.

Then we can simply fix the bug with a one-liner:
    [PATH proto] xv: Add align. pad in struct AdaptorInfo


I hope I haven't overlooked and missed alternative code paths for the
iterator.


Cheers,
    Daniel Martin


More information about the Xcb mailing list