[Xcb] [PATCH libxcb] xcb.h: add 'struct' before xcb_setup_t, xcb_query_extension_reply_t

Peter Harris peter at harr.ca
Sun Jun 29 08:51:42 PDT 2014


On Sun, Jun 29, 2014 at 6:33 AM, Alexander Mezin wrote:
> These structs are typedef'ed in xproto.h, so in xcb.h these types
> (without 'struct') are actually undefined.

Thanks for the patch. However, I'm not convinced it is necessary.
xcb.h does, in fact, include xproto.h before using those types:

http://cgit.freedesktop.org/xcb/libxcb/tree/src/xcb.h#n192

> GCC reports this as error when building precompiled header.

Did you try to generate a precompiled header before generating
xproto.h (and the rest of libxcb)? What was the exact command that
produced an error?

Thanks,
 Peter Harris


More information about the Xcb mailing list