[Xcb] [PATCH libxcb] xcb.h: add 'struct' before xcb_setup_t, xcb_query_extension_reply_t

[Peter Harris]

On Sun, Jun 29, 2014 at 2:17 PM, Alexander Mezin wrote:
> 2014-06-29 22:51 GMT+07:00 Peter Harris <peter at harr.ca>:
>> On Sun, Jun 29, 2014 at 6:33 AM, Alexander Mezin wrote:
>> Thanks for the patch. However, I'm not convinced it is necessary.
>> xcb.h does, in fact, include xproto.h before using those types:
>>
>> http://cgit.freedesktop.org/xcb/libxcb/tree/src/xcb.h#n192
> After further testing:
> Everything is ok when xcb.h is included.
> Things go wrong when xproto.h is included without xcb.h (or after xproto).
>
>> Did you try to generate a precompiled header before generating
>> xproto.h (and the rest of libxcb)? What was the exact command that
>> produced an error?
> I have file "test.h" with single line:
> #include <xcb/xproto.h>
> The command is gcc test.h

Ah, circular includes. Thanks for clarifying.

For the original patch,
Reviewed-by: Peter Harris <pharris at opentext.com>

Peter Harris