[Xcb] [PATCH libxcb 4/4] Add an AUTHORS file to recognize XCB authors

Gaetan Nadon memsize at videotron.ca
Thu Mar 27 08:21:09 PDT 2014


On 14-03-27 03:52 AM, Alan Coopersmith wrote:
>> (-s serves the same function as the "sort -u", and the cut command
>> removes the commit counts that -s adds.)
>
> Ah, I'd looked at git shortlog, but missed the -s option and instead
> went looking for format options to remove commit titles and found none.
>
> That works for me, and even takes care of the multiple email address
> merges, though we could still use .mailmap to clean up a couple
> inconsistently spelled names.  (Would be nice to have a global mailmap
> across all Xorg/xcb repos, but I don't want to figure out the git
> magic to make that work myself.)
>
Do you want output sorted by number of commits (which do not appear) or
by authors name?
The latter would require 'git shortlog -s | cut -f2- > AUTHORS'. Sorting
by commit numbers will result in a file that is constantly (ok, often)
changing. Reading it to find a name is more difficult.

Should this be made available to all xorg modules in util/macros? I have
prototyped it.
The makefile would look like in participating modules (under no obligation):

    MAINTAINERCLEANFILES = ChangeLog INSTALL AUTHORS

    .PHONY: ChangeLog INSTALL AUTHORS

    INSTALL:
        $(INSTALL_CMD)

    ChangeLog:
        $(CHANGELOG_CMD)

    AUTHORS:
        $(AUTHORS_CMD)

    dist-hook: ChangeLog INSTALL AUTHORS


 1. In any case I need an rb line for COPYING which I believe is correct.

 2. If you elect for an AUTHORS file in git, I'll amend patch #4 with
    your choice of sorting

 3. If you elect for a util-macros implementation, I'll drop patch #4
    and submit new patches after this series has been dealt with.

Thanks for the review!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20140327/6dbe4494/attachment.html>


More information about the Xcb mailing list