[Xcb] [PATCH RESEND image 03/12] config: remove old dead code for documentation

Josh Triplett josh at joshtriplett.org
Thu Mar 27 12:13:44 PDT 2014


On Thu, Mar 27, 2014 at 02:37:06PM -0400, Gaetan Nadon wrote:
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

Reviewed-by: Josh Triplett <josh at joshtriplett.org>

One note below.

>  .gitignore        |    1 -
>  configure.ac      |    3 +--
>  xcb_util_intro.in |   24 ------------------------
>  3 files changed, 1 insertion(+), 27 deletions(-)
>  delete mode 100644 xcb_util_intro.in
> 
> diff --git a/.gitignore b/.gitignore
> index fa4026e..c9f356c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -76,4 +76,3 @@ core
>  #		Edit the following section as needed
>  # For example, !report.pc overrides *.pc. See 'man gitignore'
>  #
> -xcb_util_intro
> diff --git a/configure.ac b/configure.ac
> index 603f46e..7a31623 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -17,6 +17,5 @@ PKG_CHECK_MODULES(XCB_UTIL, xcb-util)
>  
>  AC_CONFIG_FILES([Makefile
>  	image/Makefile
> -	image/xcb-image.pc
> -	xcb_util_intro])
> +	image/xcb-image.pc])

This is a good argument that the previous patch should put the "])" on a
line by itself (and the same with the "AC_CONFIG_FILES(["), to avoid
spurious extra changes when making changes near the ends of the list.

>  AC_OUTPUT
> diff --git a/xcb_util_intro.in b/xcb_util_intro.in
> deleted file mode 100644
> index f063613..0000000
> --- a/xcb_util_intro.in
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -/** 
> - at file
> - at brief XCB Utility functions
> - 
> -These routines are used to facilitate the use of XCB in programs.
> -*/
> -
> -/**
> -
> - at mainpage XCB Utility Documentation
> - at version @PACKAGE_VERSION@
> - at author Ian Osgood <iano at quirkster.com>
> - at author Bart Massey <bart at cs.pdx.edu>
> - at author Jamey Sharp <jamey at minilop.net>
> - at author Josh Triplett <josh at freedesktop.org>
> - at author Keith Packard <keithp at keithp.com>
> - at author Vincent Torri <torri at iecn.u-nancy.fr>
> - at author Julien Danjou <julien at danjou.info>
> - at author Arnaud Fontaine <arnau at debian.org>
> - at date 2005-2008
> -
> - at section intro What is available ?
> -
> -*/
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list