[Xcb] [PATCH RESEND image 06/12] make: there should be no attempt to remove any Makefile.in file

Josh Triplett josh at joshtriplett.org
Thu Mar 27 12:18:34 PDT 2014


On Thu, Mar 27, 2014 at 02:37:09PM -0400, Gaetan Nadon wrote:
> Files generated by autoconf (and the various tools it calls) must not be
> removed by running a makefile. This is outside the scope of the makefile.
> 
> http://lists.gnu.org/archive/html/autoconf/2007-03/msg00043.html
> 
> One can use git-clean to return to the original state of the module prior
> to running autogen.sh, autoreconf or configure.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

Reviewed-by: Josh Triplett <josh at joshtriplett.org>

Nit below.

>  image/Makefile.am |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/image/Makefile.am b/image/Makefile.am
> index f6a67ff..84c5c3e 100644
> --- a/image/Makefile.am
> +++ b/image/Makefile.am
> @@ -1,4 +1,3 @@
> -MAINTAINERCLEANFILES = Makefile.in
>  

Please drop the blank line as well.

>  lib_LTLIBRARIES = libxcb-image.la
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list