[Xcb] [PATCH RESEND image 11/12] test: use AM_CPPFLAGS rather than per-target test_swap_CPPFLAGS aand others

Gaetan Nadon memsize at videotron.ca
Fri Mar 28 06:08:12 PDT 2014


On 14-03-27 08:45 PM, Josh Triplett wrote:
> First of all, if it can be removed, great; however, you should document
> that clearly in the commit message, and perhaps do it as a separate
> commit for clarity.
Absolutely. It was originally a mistake on my part to have a second
change unaccounted for.
In light of the review, I'll drop this patch #11 and write a new one
with the "inline" in there.

Might as well post a v2 of this series for clarity as there are other
minor changes.

Thanks for this excellent review.


More information about the Xcb mailing list