[Xcb] [PATCH libxcb 1/3] generator: support fixed size lists in var-sized structs

Ran Benita ran234 at gmail.com
Tue Sep 9 09:45:38 PDT 2014

On Fri, Sep 05, 2014 at 05:08:43PM +0200, Christian Linhart wrote:
> On 09/05/14 15:20, Ran Benita wrote:
> > On Thu, Aug 21, 2014 at 10:35:54PM +0200, Christian Linhart wrote:
> >> ---
> > 
> > This should work AFAICT:
> > Reviewed-by: Ran Benita <ran234 at gmail.com>
> > 
> > Some stylistic nits below if you care..
> Thank you for mentioning that.
> Is it OK when I do the stylistic stuff in one extra patch after finishing the complete XInput work?
> This will be much easier and will avoid confusion with too many patch-versions etc.

I see you handled everything in the branches, thanks. So there's no
reason to send versions for the style fixes as far as I go.

> Is there a style-guide somewhere which lists these style-rules?

For C code, the following seems about appropriate:

For python code I'd say PEP-8 is mostly accepted by everybody:

But if you're working with existing code, best is just to try and look
the same, as if the entire file was written by the same person.

> Chris

More information about the Xcb mailing list