[Xcb] [PATCH] shm: Mark PutImage.send_event field as boolean

[Christian Linhart]

Hi Robert,

Thank you for this patch.
The spec [1] says that this is a bool, so your patch is good.
BOOL and CARD8 are ABI/API compatible, so this is OK from that perspective, too.

Therefore:
Reviewed-by: Christian Linhart <chris at demorecorder.com>

Cheers,

Chris

References:
[1] http://cgit.freedesktop.org/xorg/proto/xextproto/tree/specs/shm.xml



On 08/27/15 11:37, Robert Ancell wrote:
> ---
>  src/shm.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shm.xml b/src/shm.xml
> index 71fce14..c2605da 100644
> --- a/src/shm.xml
> +++ b/src/shm.xml
> @@ -79,7 +79,7 @@ authorization from the authors.
>      <field type="INT16" name="dst_y" />
>      <field type="CARD8" name="depth" />
>      <field type="CARD8" name="format" />
> -    <field type="CARD8" name="send_event" />
> +    <field type="BOOL" name="send_event" />
>      <pad bytes="1" />
>      <field type="SEG" name="shmseg" />
>      <field type="CARD32" name="offset" />