[Xcb] [PATCH 1/2] Add missing defines for X11 opcodes

[Peter Harris]

On 25 December 2015 at 13:23, Klemens Baum <klemensbaum at gmail.com> wrote:
> This patch adds the XCB_ERROR, XCB_REPLY and XCB_GE_EVENT symbolic constants.
> These are intended to be used for disambiguating xcb_generic_event_t.

Thanks for the patch series.

XCB_ERROR and XCB_REPLY seem like a good idea, but XCB_GE_EVENT
already exists in a public header. It's spelled "XCB_GE_GENERIC" and
can be found in xproto.h. Since xproto.h is already (indirectly)
included in xcb_in.c, perhaps XCB_GE_GENERIC could be used in place of
XCB_GE_EVENT in xcb_in.c

Also, there seems to be a fair number of unnecessary code motion,
comment, and whitespace changes in this patch, which makes it more
difficult to review.

Peter Harris