[Xcb] [PATCH] xfixes: cursor-name is after cursor-image in GetCursorImageAndName

[Christian Linhart]

Hi Peter,

Thank you for finding and fixing that.
I suggest that you post a patch for fixesproto.txt on xorg-devel,
so that implementation and spec will be in sync.

I have looked at the implementation in libXFixes and Xserver
and this confirms what you have found out.

Your patch looks good, therefore:

Reviewed-by: Christian Linhart <chris at demorecorder.com>

Regards,

Chris


On 02/04/15 00:31, Peter Harris wrote:
> The current version of fixesproto.txt has cursor-name before
> cursor-image, but all known implementations put cursor-name after
> cursor-image on the wire.
>
> Signed-off-by: Peter Harris <pharris at opentext.com>
> ---
>  src/xfixes.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xfixes.xml b/src/xfixes.xml
> index c5cba35..0a3d5ff 100644
> --- a/src/xfixes.xml
> +++ b/src/xfixes.xml
> @@ -291,13 +291,13 @@ authorization from the authors.
>        <field type="ATOM"   name="cursor_atom" altenum="Atom" />
>        <field type="CARD16" name="nbytes" />
>        <pad bytes="2" />
> -      <list  type="char"   name="name"><fieldref>nbytes</fieldref></list>
>        <list  type="CARD32" name="cursor_image">
>          <op op="*">
>            <fieldref>width</fieldref>
>            <fieldref>height</fieldref>
>          </op>
>        </list>
> +      <list  type="char"   name="name"><fieldref>nbytes</fieldref></list>
>      </reply>
>    </request>
>