[Xcb] [PUSHED] [PATCH proto] xinput: align XIChangeProperty data items correctly

Christian Linhart chris at DemoRecorder.com
Sat Jul 4 06:59:55 PDT 2015


Pushed to the main repo.

On 06/12/15 10:25, Christian Linhart wrote:
> Hi Peter,
>
> These aligns will be put at the end of the XIChangeProperty request
> because the "case" branches are mutually exclusive. In that sense
> it differs from 055c13096d94953de9ca62017f917572bd0e3f56
> where bitcase is used.
>
> But it is a good idea anyways to have proper alignment at the end
> of protocol entities. This will be especially important when we'll do
> automatic verification of protocol definitions.
>
> Therefore:
> Reviewed-by: Christian Linhart <chris at demorecorder.com>
>
> Cheers,
>
> Chris
>
> On 06/12/15 06:15, Peter Hutterer wrote:
>> Items need to be 4-aligned, see also 055c13096d94953de9ca62017f917572bd0e3f56
>>
>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>> ---
>>  src/xinput.xml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/xinput.xml b/src/xinput.xml
>> index c729f20..6564f4c 100644
>> --- a/src/xinput.xml
>> +++ b/src/xinput.xml
>> @@ -1985,12 +1985,14 @@ This affects the following:
>>                  <list type="CARD8" name="data8">
>>                      <fieldref>num_items</fieldref>
>>                  </list>
>> +                <pad align="4" />
>>              </case>
>>              <case>
>>                  <enumref ref="PropertyFormat">16Bits</enumref>
>>                  <list type="CARD16" name="data16">
>>                      <fieldref>num_items</fieldref>
>>                  </list>
>> +                <pad align="4" />
>>              </case>
>>              <case>
>>                  <enumref ref="PropertyFormat">32Bits</enumref>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb



More information about the Xcb mailing list