[Xcb] [PATCH Xlib 1/3] Hoist most of _XConnectXCB into XOpenDisplay, and simplify

Mike Blumenkrantz zmike at samsung.com
Wed Jun 17 12:28:30 PDT 2015

On Thu, 11 Jun 2015 16:54:36 -0400
Mike Blumenkrantz <zmike at samsung.com> wrote:

> On Thu, 11 Jun 2015 12:37:10 -0700
> Alan Coopersmith <alan.coopersmith at oracle.com> wrote:
> > On 06/11/15 11:24 AM, Mike Blumenkrantz wrote:
> > > Commit by Josh Triplett and Jamey Sharp.
> > 
> > Why is this useful?  It would really help if the commit comment had
> > explanation, as suggested in
> > http://who-t.blogspot.com/2009/12/on-commit-messages.html -
> > otherwise it's a hard to review code dump, which for X, probably
> > means it goes nowhere, as we don't have enough reviewers to reverse
> > engineer code changes.
> > 
> This is a prep commit for the function added later in the series. It
> refactors the code to reduce duplication later on when there are two
> functions which will be using the same code paths.

To elaborate further, this patch series will be useful for anyone
wishing to implement XWayland functionality using Xlib. The
X11 connection must be opened from a file descriptor using XCB, and so
some method of opening a Display object from that XCB connection is
necessary. These patches add that method while reducing code
duplication to a minimum and, hopefully, still allowing multithreaded
Xlib connections to function as expected.

More information about the Xcb mailing list