[Xcb] [PATCH proto 1/2 RESEND] xml-xcb.txt: mention that case/bitcase can have a name

Christian Linhart chris at DemoRecorder.com
Sat May 30 03:22:21 PDT 2015


Hi Ran,

Thank you for the updated patch and sorry for my delayed review.

Your patch inserts a missing piece into the documentation.
Thank you for catching that.

Therefore:
Reviewed-by: Christian Linhart <chris at demorecorder.com>

I will push this patch right now because there was more than enough time for other reviews.

Chris

On 03/18/15 11:27, Ran Benita wrote:
> Signed-off-by: Ran Benita <ran234 at gmail.com>
> ---
>  doc/xml-xcb.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/xml-xcb.txt b/doc/xml-xcb.txt
> index f8129ea..8d914a1 100644
> --- a/doc/xml-xcb.txt
> +++ b/doc/xml-xcb.txt
> @@ -244,8 +244,8 @@ enum; the value is restricted to one of the constants named in the enum.
>    <switch> instead for new protocol definitions.
>  
>  <switch name="identifier"> switch expression
> -    <bitcase> bitcase expression(s), fields </bitcase>
> -    <case> case expression(s), fields </case>
> +    <bitcase [name="identifier"]> bitcase expression(s), fields </bitcase>
> +    <case [name="identifier"]> case expression(s), fields </case>
>  </switch>
>  
>    This element represents conditional inclusion of fields. It can be viewed



More information about the Xcb mailing list