[Xcb] [PUSHED] [PATCH 2/2] glx: Add IsEnabled request

Christian Linhart chris at DemoRecorder.com
Sun Sep 13 01:59:41 PDT 2015

Hi Robert and Peter,

This looks good.
The server-code  of IsEnabled is almost identical to IsList.
Therefore, the xml should be almost identical, too.
Which is the case in your patch.

Reviewed-by: Christian Linhart <chris at demorecorder.com>

I have pushed this patch now because it has waited enough time for additional reviews.



On 08/31/15 16:29, Peter Harris wrote:
> On 2015-08-30 08:30, Christian Linhart wrote:
>> Hi Robert,
>> Can you please post a link to the spec of this request? (or to sourcecode in server or xlib which currently implements this request)
> Server source code:
> http://cgit.freedesktop.org/xorg/xserver/tree/glx/indirect_dispatch.c#n2215
> Mesa's XML (which is a different format from XCB XML):
> http://cgit.freedesktop.org/mesa/mesa/tree/src/mapi/glapi/gen/gl_API.xml#n2843
> Both of these agree with the proposed patch. Therefore,
> Reviewed-by: Peter Harris <pharris at opentext.com>
> Peter Harris

More information about the Xcb mailing list