[Xcb] [PATCH proto 2/9] render: make padding explicit

Christian Linhart chris at demorecorder.com
Sun Sep 13 06:45:10 PDT 2015

Add explicit align-padding for:
* the request "SetPictureFilter":
  Added 4-byte align-pad between list "filter" and list "values"
  The spec does not show the padding:
  But there has to be padding to make accesses to 32-bit values in list
  "values" aligned.
  The Xlib implementation at
  correctly does the padding:
  The string "filter" is written with "Data" which does 4-byte padding at the end:

Signed-off-by: Christian Linhart <chris at demorecorder.com>
 src/render.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/render.xml b/src/render.xml
index c54608e..935fdcc 100644
--- a/src/render.xml
+++ b/src/render.xml
@@ -603,14 +603,15 @@ <request name="QueryFilters" opcode="29">
   <request name="SetPictureFilter" opcode="30">
     <field type="PICTURE" name="picture" />
     <field type="CARD16" name="filter_len" />
     <pad bytes="2" />
     <list type="char" name="filter">
+    <pad align="4" />
     <list type="FIXED" name="values" />
   <!-- new in version 0.8 -->
   <struct name="ANIMCURSORELT">
     <field type="CURSOR" name="cursor" />

More information about the Xcb mailing list