[Xcb] [PATCH] Add missing alignment padding to SetupRequest struct

[Christian Linhart]

Hi Alessandro,

Sorry for this patch being uncommitted for so long and thank you for the reminder.

Reasons for missing to include it in 1.12.:
None of us volunteers had the time to go through the list of
uncommitted patches in patchwork. And nobody else volunteered to do that.
We have some serious lack of people willing to do work for XCB. :-(

Second reason: version 1.12. had to be rushed out due to some critical bugfix
with respect to 64/32 bit issues.

I was completely away from the project for more than a year or so.
But I am returning. At least in the role of making some changes in the code.
See the patches that I have posted recently.

I'll push your patch soon.

Chris

P.S.: Do you want to volunteer for doing work for XCB? ;-)

Seriously, we need somebody doing secretary/assistant type of work
like checking for uncommitted patches that have a thumbs up from reviewers etc.

Any volunteers?

On 2017-01-23 17:21, Alessandro Arzilli wrote:
> Any reason this was not merged for xcb-proto 1.12?
>
> Alessandro Arzilli.
>
> On 13/09/2015 12:49, aarzilli wrote:
>> Fields  AuthorizationProtocolName and AuthorizationProtocolData of
>> SetupRequest should be padded:
>>
>> http://www.x.org/releases/current/doc/xproto/x11protocol.html#Encoding::Connection_Setup
>>
>> The problem was discovered by github user pphaneuf while trying to use xgb
>> to write his own implementation of the connection handshake. Neither xgb
>> nor xcb actually use code generated for SetupRequest for the handshake,
>> which is why this bug went unnoticed.
>>
>> https://github.com/BurntSushi/xgb/issues/24
>>
>> Alessandro Arzilli.
>>
>> ---
>>  src/xproto.xml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/xproto.xml b/src/xproto.xml
>> index bfb8a4c..143318b 100644
>> --- a/src/xproto.xml
>> +++ b/src/xproto.xml
>> @@ -195,9 +195,11 @@ authorization from the authors.
>>      <list type="char" name="authorization_protocol_name">
>>        <fieldref>authorization_protocol_name_len</fieldref>
>>      </list>
>> +    <pad align="4" />
>>      <list type="char" name="authorization_protocol_data">
>>        <fieldref>authorization_protocol_data_len</fieldref>
>>      </list>
>> +    <pad align="4" />
>>    </struct>
>>
>>    <struct name="SetupFailed">
>>
>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/xcb