SYNC extension: misalignment of system counter structs?

[Bart Massey]

Reading the ancient discussion on this, I think Peter Harris had the right
of it. It would probably be good to treat all protocol description structs
as packed, and add explicit pad fields in the protocol description to match
the protocol spec. It looks like modern C compilers support
__attribute__((__packed__)) structs pretty well? I'm not sure how much of
the protocol description would have to be touched, though. Is it just the
stuff in Uli Shlacter's excellent list?

The easy thing, of course, would be to just take Daniel Martin's fix to add
a packed attribute to protocol descriptions (assuming it works):
https://lists.freedesktop.org/archives/xcb/2012-December/008032.html

On Fri, Feb 7, 2025 at 9:05 AM Alan Coopersmith <alan.coopersmith at oracle.com>
wrote:

> On 2/7/25 07:40, Uli Schlachter wrote:
> > Hi,
> >
> > Am 06.02.25 um 21:15 schrieb Alan Coopersmith:
> >> On 2/4/25 09:46, Daniel Neugebauer wrote:
> >>> It would be great if someone could confirm the issue. See [3] for a
> test
> >>> implementation incl. a local workaround. Is there anything I'm doing
> wrong on
> >>> my end?
> >
> > I can confirm the issue and I can add that it is known:
> >
> > https://gitlab.freedesktop.org/xorg/lib/libxcb/-/issues/36
> > https://bugs.freedesktop.org/show_bug.cgi?id=23403
>
> Ah right, I had clearly forgotten all about this in the past 13 years.
>
> >> So while I can confirm, I don't know how to fix it.
> >
> > Alan from the past also has a test case for reproducing this. See
> bugs.fdo link
> > above. :-)
>
> Heh, and now that I've been reminded, I found that old test case, so now
> have
> two!  If only Alan from the past had actually come up with a real fix...
>
> --
>          -Alan Coopersmith-                 alan.coopersmith at oracle.com
>           Oracle Solaris Engineering - https://blogs.oracle.com/solaris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/xcb/attachments/20250207/24260730/attachment.htm>