Yes, that is fine. I didn't think this patch was a permanent fix, it was a workaround for an issue I had while initially packaging. If the problem shows up again I'll get back in touch. Cheers, Kristoffer <div class="gmail_quote"><div dir="ltr">On Mon, Apr 25, 2016, 12:58 Stefan Dirsch <<a href="mailto:sndirsch@suse.de">sndirsch@suse.de</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Apr 25, 2016 at 10:45:17AM +0200, Kristoffer Grönlund wrote: > >> cursor_shape_to_id should not be declared const, else it is not added > >> to the static library. > > > > Huh? Why not? What does GCC do different for static libraries? What does GCC > > even have to do with libraries at all (instead of e.g. the linker)? What does > > "not addeed to the static library" mean? What exactly are you doing and what's > > the error message? > > > > (Note that static libraries contain .o files and not functions...) > > > > Also: "Fix issue with gcc": Sorry, but my gcc works fine here, could you be more > > specific. > > I wish I could, but I created that patch in 2013 and I no longer have > any memory nor any local trace of what version of GCC I was using. My > guess however is that it is a more recent version of GCC than what you > are using. > > Here's my wild guess as to what was going on: If all parameters to the > function are const and the return value is also const, it seems that > at least on the OBS at that time, GCC would decide to inline the > function out of existence, which led to the linker complaining that > the function doesn't exist. > > I think that I encountered this while building awesome [1], if that helps. > > [1]: <a href="https://awesome.naquadah.org/" rel="noreferrer" target="_blank">https://awesome.naquadah.org/</a> Kristoffer, since we don't provide a static lib for libxcb-cursor (did we really at that time?), I suggest to remove this patch from our package sources and no longer pursue to bring it upstream. Is this ok for you? Thanks, Stefan Public Key available ------------------------------------------------------ Stefan Dirsch (Res. & Dev.) SUSE LINUX GmbH Tel: 0911-740 53 0 Maxfeldstraße 5 FAX: 0911-740 53 479 D-90409 Nürnberg <a href="http://www.suse.de" rel="noreferrer" target="_blank">http://www.suse.de</a> Germany --------------------------------------------------------------- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --------------------------------------------------------------- </blockquote></div>