<div dir="ltr">Guys,<div><br></div><div>I think this patch is currently harmless and makes support to clang to properly compile it.</div><div><br></div><div><span style="font-family:monospace"><span style="color:rgb(0,0,0)">Author: Pablo Cholaky <<a href="mailto:waltercool@slash.cl">waltercool@slash.cl</a>>
</span><br>Date:   Sat Oct 8 16:52:37 2016 -0300
<br>
<br>    Added return to xcb_host_byte_order function
<br>     <br>    Signed-off-by: Pablo Cholaky <<a href="mailto:waltercool@slash.cl">waltercool@slash.cl</a>><br></span></div><div><div><br></div><div><span style="font-family:monospace"><span style="color:rgb(0,0,0)">diff --git a/image/xcb_bitops.h b/image/xcb_bitops.h </span><br>index a6872a1..bf6fdc1 100644 <br>--- a/image/xcb_bitops.h <br>+++ b/image/xcb_bitops.h <br>@@ -207,6 +207,7 @@ xcb_host_byte_order(void) { <br>      return XCB_IMAGE_ORDER_LSB_FIRST; <br>  } <br>  assert(0); <br>+  return -1; <br>} <br> <br>#endif /* __XCB_BITOPS_H__ */</span></div></div><div><div><br></div><div>Using clang it fails just after configure</div><div><br></div><div><div>Making all in image</div><div>make[2]: Entering directory '/var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0-abi_x86_64.amd64/image'</div><div>/bin/sh ../libtool  --tag=CC   --mode=compile clang -DHAVE_CONFIG_H -I. -I/var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0/image -I..       -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -O2 -pipe -g -c -o xcb_image.lo /var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0/image/xcb_image.c</div><div>libtool: compile:  clang -DHAVE_CONFIG_H -I. -I/var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0/image -I.. -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -O2 -pipe -g -c /var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0/image/xcb_image.c  -fPIC -DPIC -o .libs/xcb_image.o</div><div>In file included from /var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0/image/xcb_image.c:37:</div><div>/var/tmp/portage/x11-libs/xcb-util-image-0.4.0/work/xcb-util-image-0.4.0/image/xcb_bitops.h:210:1: error: control may reach end of non-void function [-Werror,-Wreturn-type]</div><div>}</div><div>^</div><div>1 error generated.</div></div><div><br></div><div>Based on the patch initially proposed here: <a href="https://patchwork.openembedded.org/patch/118073/">https://patchwork.openembedded.org/patch/118073/</a> and discussed here <a href="https://github.com/gentoo/gentoo/pull/2496">https://github.com/gentoo/gentoo/pull/2496</a> and here <a href="https://github.com/gentoo/musl/pull/12">https://github.com/gentoo/musl/pull/12</a></div><div><br></div><div>Regards.</div><div><br></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Pablo Cholaky<br>
Computer Science and TI Engineer<br>
Gentoo Linux user and developer<br>
Slash.cl Owner<br>
Blablabla</div></div>
</div></div>