[PATCH] Re: HAL 0.1 release

[David Zeuthen]

On Thu, 2003-11-06 at 23:16, Martin Waitz wrote:
> hi :)
> 
> some minor changes...
> i'll hope to come up with real patches later ;)
> 

Many thanks for the patch; note that due design changes and the API
churn in D-BUS, I have moved the old source-tree out of the way (to
module hal-old) and started a new tree in place of the old; I just
committed my initial work there, but it's rather incomplete still. I
will however, incorporate your patches in the new tree.

> i needed this to get hald to connect to dbus correctly:
> 
> --- hal-0.1.orig/hal.conf
> +++ hal-0.1/hal.conf
> @@ -56,6 +56,8 @@
>      <allow send="org.freedesktop.Hal.libhal.DeviceEnabled"/>
>      <allow send="org.freedesktop.Hal.libhal.DeviceRequireUser"/>
>      <allow send="org.freedesktop.Hal.libhal.DevicePropertyChanged"/>
> +
> +    <allow own="org.freedesktop.Hal"/>
>    </policy>
>  
>  </busconfig>
> 

Ok; the security policy has changed in D-BUS so I'll probably screw up
again :-)

> i think these programs belong to sbin instead of bin.
> or put everything into sbin?
>
> --- hal-0.1.orig/hald/Makefile.am
> +++ hal-0.1/hald/Makefile.am
> @@ -6,7 +6,7 @@
>  	-DPACKAGE_LOCALE_DIR=\""$(prefix)/$(DATADIRNAME)/locale"\" \
>  	@PACKAGE_CFLAGS@
>  
> -bin_PROGRAMS = hald
> +sbin_PROGRAMS = hald


The hal daemon and programs (in hal 0.2, hal_agents) to be invoked by
hotplug should belong in sbin, yes. The rest should go in bin as normal
users / programs can use them.

> the following are needed for packaging hal:
> 

Ok - makes sense.

By the way, it's a bit unclean that one has to specify to the hal
configure script where (/etc/dbus-1/)system.d from D-BUS is. Is there
any way the dbus-1.pc can tell me that?
(my thinking is that $prefix is not sufficient, because does it mean
/etc or /usr/etc?)

Thanks,
David