menu-spec: Excluded items are Unllocated

[Waldo Bastian]

On Friday 18 February 2005 17:09, Mark McLoughlin wrote:
> On Thu, 2005-02-03 at 22:48 +0100, Waldo Bastian wrote:
> > Ok, I have adjusted the KDE menu to take this change into account but I
> > am still left with a failed regression test "m".
> >
> > The problem is basically that KDE considers menu entries that are
> > allocated to a menu that is hidden as allocated, while the test case
> > doesn't consider them to be allocated.
> >
> > So the test-case puts kwrite, kedit and kate in the "Other" menu, while
> > KDE puts them in the "Hidden" menu.
> >
> > I don't think that hiding a menu should influence the allocation.
>
> 	Okay, I agree and it seems that's what the GNOME implementation is
> doing anyway.
>
> 	One problem though - your results show the "Hidden" menu, but it
> shouldn't be displayed at all because the .directory file has
> NoDisplay=true. I think that was the real purpose behind the "m" test
> case.

Yes, I agree.

> > The next question is, how should the result look like when the menu was
> > <Deleted/> instead of hidden. I have added testcase "n" for that for now.
> > I think that also in this case kwrite, kedit and kate should not appear
> > in the "Other" menu.
>
> 	Yep, so the output from both "m" and "n" should be:
>
>  Other/ freecell.desktop       
> /tmp/menutestdir/xdg_data_dir/applications/freecell.desktop
>
> 	I just went ahead and committed ...

Great, thanks.

Cheers,
Waldo
-- 
bastian at kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian at suse.com  |   http://www.novell.com/products/desktop/eval.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xdg/attachments/20050218/f2a2a6a2/attachment.pgp