[PATCH] hicolor-icon-theme and autoconf >= 2.60

andreas.hanke at gmx-topmail.de andreas.hanke at gmx-topmail.de
Thu Mar 1 04:14:16 EET 2007


Hi,

I'm resending this patch because it hasn't been sufficiently dealt with so far.

Summarizing the problem again: hicolor-icon-theme (called icon-theme/default-icon-theme in CVS) has a Makefile.in that uses @datadir@ and expects configure, generated by autoconf, to expand it. But in autoconf >= 2.60, @datadir@ is no longer directly derived from @prefix@; it is now derived from a new variable called @datarootdir at .

This results in warnings like these:

configure: creating ./config.status
config.status: creating Makefile
config.status: WARNING:  Makefile.in seems to ignore the --datarootdir setting

The obvious fix is to make Makefile.in no longer ignore the --datarootdir setting.

I'd also like to emphasize that this is not caused by a mistake on my side and it cannot be fixed by re-running automake because hicolor-icon-theme does not use automake! Makefile.in is written manually and therefore needs to be fixed manually. Please read http://www.gnu.org/software/autoconf/manual/html_node/Changed-Directory-Variables.html

Andreas Hanke
-- 
"Feel free" - 5 GB Mailbox, 50 FreeSMS/Monat ...
Jetzt GMX ProMail testen: www.gmx.net/de/go/mailfooter/promail-out
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hicolor-icon-theme-datarootdir.patch
Type: text/x-patch
Size: 227 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/xdg/attachments/20070301/b3481853/attachment.bin 


More information about the xdg mailing list